superduper-io / superduper

Superduper: Integrate AI models and machine learning workflows with your database to implement custom AI applications, without moving your data. Including streaming inference, scalable model hosting, training and vector search.
https://superduper.io
Apache License 2.0
4.65k stars 448 forks source link

Misleading text #2356

Closed fnikolai closed 11 hours ago

fnikolai commented 1 month ago

The following text appears when unable to connect to ray. Instead the proper message should say that we are unable to connect.

| /home/superduper/.local/lib/python3.10/site-packages/snowflake/sqlalchemy/base.py:1068: SAWarning: The GenericFunction 'flatten' is already registered and is going to be overridden.            |
|   functions.register_function("flatten", flatten)                                                                                                                                                |
| INFO:     Application startup complete.                                                                                                                                                          |
| INFO:     Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit)                                                                                                                          |
| 2024-Jul-30 11:31:46.86| ERROR    | statefulset-0| superduper_services.cdc.cdc:301  | In DatabaseListenerThreadScheduler LocalComputeBackend.broadcast() got an unexpected keyword argument 'to' |
| Traceback (most recent call last):                                                                                                                                                               |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 299, in run                                                                                                   |
|     self.listener.next_cdc(cdc_stream)                                                                                                                                                           |
|   File "/home/superduper/superduper_services/superduper_services/cdc/ibis/listener.py", line 221, in next_cdc                                                                                    |
|     self.event_handler(ids, event=cdc.DBEvent.insert)                                                                                                                                            |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 260, in event_handler                                                                                         |
|     self.on_create(ids, self.db, self._on_component)                                                                                                                                             |
|   File "/home/superduper/superduper_services/superduper_services/cdc/ibis/listener.py", line 194, in on_create                                                                                   |
|     self.create_event(                                                                                                                                                                           |
|   File "/home/superduper/superduper_services/superduper_services/cdc/cdc.py", line 236, in create_event                                                                                          |
|     db.compute.broadcast(events, to=deps)                                                                                                                                                        |
| TypeError: LocalComputeBackend.broadcast() got an unexpected keyword argument 'to'  
fnikolai commented 1 month ago

image

kartik4949 commented 1 month ago

@fnikolai Because of version mismatch services version and superduper version both should be latest

we need a version check at startup probably in future.

If you check latest version of services repo we are not doing db.compute.boardcast(events, to=deps) the latest code is db.compute.boardcast(events)