search

superfaceai / cli

Let AI connect the APIs for you
https://superface.ai
MIT License
23 stars 4 forks source link

[Feedback] avoid generating `unknown.provider.json` #354

Closed julpat closed 1 year ago

julpat commented 1 year ago

Feedback

After superface prepare users can get into a situation when unknown.provider.json is created. The next steps are confusing for the user (should I continue with "unknown" and get lost or do I must spend some time on it to find out why it is "unknown"). image

Possible solutions:

a) Find a different way how to get at least the provider name if generating the whole provider.json is not possible. b) Ask for the provider's name before finishing the prepare command (if the name can not be created automatically). c) Consider command execution as failed; Guide to run it again with the provider name argument.

cc @rak-superface

Jakub-Vacek commented 1 year ago

This was partially addressed in https://github.com/superfaceai/cli/pull/352 (for provider name inferred form filename). b) - won't be possible because we would need to change our worker implementation.

Personally, I would go with C and we should also go through the cases when unknown happens and try to mitigate them.

Jakub-Vacek commented 1 year ago

PR mitigating this issue were merged and deployed