Closed Jakub-Vacek closed 1 year ago
I can ask Eda :)
Not sure about major - technically all of deleted commands were already hidden from public API.
I talked with @TheEdward162 about minor/major. He is fine with both, I would go with minor. cc @kysely
My thinking behind major was that although this doesn't change the exposed interface, it still has breaking changes to the implementation. But I guess no one's really using these commands anyway 🤷♂️
Description
This PR removes dependency on old pre 3.0.0 SDK and all the related commands/code. I used knip to detect dead code.
Files worth checking out are the modified (not removed) files.
Motivation and Context
Types of changes
Checklist: