feat: prepare force flag

superfaceai / cli

Let AI connect the APIs for you

https://superface.ai

MIT License

22 stars 4 forks source link

feat: prepare force flag #373

Closed Jakub-Vacek closed 9 months ago

Jakub-Vacek commented 10 months ago

Description

This PR adds force flag to prepare command, this flag allows reindexing of existing provider

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly. For updating Oclif commands documentation use oclif-dev.
[ ] I have read the CONTRIBUTING document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Jakub-Vacek commented 10 months ago

Looks fine.

One question though — when initially discussing this on a call, didn't we agree that CLI will automatically set/retry the force flag is the provider already exists? Or what is with something else?

Yes we did and decided that it is optional. I wanted to focus more on AI related tasks (provider gen, analysis) but if you think we should implement it I will do it :)

kysely commented 10 months ago

Looks fine. One question though — when initially discussing this on a call, didn't we agree that CLI will automatically set/retry the force flag is the provider already exists? Or what is with something else?

Yes we did and decided that it is optional. I wanted to focus more on AI related tasks (provider gen, analysis) but if you think we should implement it I will do it :)

Hmm, I thought this optionality means “if we have time to do it, let's do it”, but this feature means:

if provider already exists, ask user if they want to rewrite it, then retry the request with force flag

But probably let's not do it now if you don't feel like it

Jakub-Vacek commented 10 months ago

With all the new features needed in engine I would skip this - maybe I will add it when I have some time :)