fix: Return security and deprecate it - Githubissues

superfaceai / one-sdk-js

1️⃣ One Node.js SDK for all the APIs you want to integrate with

https://superface.ai

MIT License

46 stars 3 forks source link

fix: Return security and deprecate it #249

Closed lukas-valenta closed 2 years ago

lukas-valenta commented 2 years ago

Description

Returns security field to ProviderConfiguration and deprecates it

Motivation and Context

Removing the field was a breaking change because it's a part of public interface

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Jakub-Vacek commented 2 years ago

Suggestion: update changelog?