Metrics reporting without super.json - Githubissues

superfaceai / one-sdk-js

1️⃣ One Node.js SDK for all the APIs you want to integrate with

https://superface.ai

MIT License

46 stars 3 forks source link

Metrics reporting without super.json #268

Closed freaz closed 2 years ago

freaz commented 2 years ago

Description

Setting up metrics reporting without super.json and changing super.json to be uptional for MetricReporter instance.

Client will skip SDKInit event reporting if super.json is not present.

This requires changes in backend services, which are done in https://github.com/superfaceai/brain/pull/434

Motivation and Context

We want reporting of performs even without super.json. But SDKInit doesn't need to be send as it doesn't have any value.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.