Align errors - Githubissues

superfaceai / one-sdk-js

1️⃣ One Node.js SDK for all the APIs you want to integrate with

https://superface.ai

MIT License

46 stars 3 forks source link

Align errors #273

Closed freaz closed 2 years ago

freaz commented 2 years ago

Description

Take it as suggestion, I am not still 100% sure if I broke something, so I wanted to open PR and read though it

I am trying to change it so all errors inherit from native Error.

Motivation and Context

Welp, I believe error should be an actual error.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
[ ] I have read the CONTRIBUTING document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

freaz commented 2 years ago

Changes in PR were superseded by changed error structure in #258