feat: Remove parser - Githubissues

superfaceai / one-sdk-js

1️⃣ One Node.js SDK for all the APIs you want to integrate with

https://superface.ai

MIT License

46 stars 3 forks source link

feat: Remove parser #276

Closed lukas-valenta closed 2 years ago

lukas-valenta commented 2 years ago

Description

Removes the parser dependency completely

Motivation and Context

Parser is too big of a dependency and we decided it would be better to remove it now altogether and perhaps return it as an optional dependency later

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Jakub-Vacek commented 2 years ago

Looks ok, I am just not sure about the fallback to map AST fetch.