Created ISandbox and move implementation to node - Githubissues

superfaceai / one-sdk-js

1️⃣ One Node.js SDK for all the APIs you want to integrate with

https://superface.ai

MIT License

46 stars 3 forks source link

Created ISandbox and move implementation to node #335

Closed freaz closed 1 year ago

freaz commented 1 year ago

Description

This adds interface for Sandbox. Which is then implemented in node.

All core uses PureJSSandbox (which isn't sandbox), to evaluate comlink script.

What I am missing is testing Sandboxes that they interpret scripts in the same way, so we can really keep using PureJSSandbox in core.

Motivation and Context

This will allows us to use different ways for sandboxing and in corner cases disable it entirely.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
[ ] I have read the CONTRIBUTING document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.