superfaceai / passport-twitter-oauth2

Twitter OAuth 2.0 Strategy for Passport for accessing Twitter API v2
MIT License
29 stars 9 forks source link

Users which are not logged in before authorization #5

Closed soya-miruku closed 1 year ago

soya-miruku commented 2 years ago

Hello, Not sure if this is an issue with this library or i am just not understanding the twitter auth flow. if a user who has not been logged in initially tries to authorize it asks them to login and with that it does not hit the callback again, how do i resolve this issue?

jnv commented 2 years ago

Hi @VinHylme, this sort of flow should work but we haven't tested it. It could be an issue on Twitter's side but I doubt it. We will check it out, thanks for the report!

soya-miruku commented 2 years ago

@jnv thanks for the quick response, please do let me know once you've confirmed as i am invested in this package

janhalama commented 2 years ago

Hi @VinHylme, I just tested the flow you described with twitter-demo app, and it works. I suggest to try our demo app or provide project which demonstrates the bug.

jnv commented 2 years ago

I can also confirm from brief test in Firefox anonymous window. Consider testing this with different browser, it's possible some extension or security restriction could be disrupting the flow. From the application's point of view, the authorization flow will be the same regardless whether the user is signed in or not.

I will take off the bug label for now, but keep this open, looking for more information.

soya-miruku commented 2 years ago

hey @jnv & @janhalama i'll have some further play around on this, really appreciate the fast response :)

jnv commented 2 years ago

@VinHylme Any more information about this?

soya-miruku commented 2 years ago

@jnv I wasn't able to get resolve this myself, so instead I decided to find a way around it, however I thought it might also be possible because i was testing on localhost that i got this error

jnv commented 1 year ago

I will close this issue due to inactivity. If the problem persists, please open a new issue.