superfaceai / service-client

Library provides client for superface backend apis.
MIT License
5 stars 1 forks source link

feat: Adding method for confirming login #45

Closed kysely closed 3 years ago

kysely commented 3 years ago

This PR adds method for confirming passwordless login.

Previously, the confirmation was done in Air using this client's fetch. I'm moving the feature as a dedicated confirmation method here because the view of service-client shifted since then to be more capable service SDK (rather than a thin wrapper over fetch). It might also be better reused among other passwordless login methods in service client.

At the same time, this fixes the issue present in Air implementation where e-mail passed to confirmation was not correctly URI-encoded.


navigable commit by commit

kysely commented 3 years ago

Good catch, thanks!