Custom query params for passwordless and GitHub authentication - Githubissues

superfaceai / service-client

Library provides client for superface backend apis.

MIT License

5 stars 1 forks source link

Custom query params for passwordless and GitHub authentication #70

Closed freaz closed 2 years ago

freaz commented 2 years ago

Description

This PR adds to passwordless and getGithubLoginUrl one more argument to be able to pass any query parameters.

Motivation and Context

We want mark users in CRM after registration with campaign they came from.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION_GUIDE document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

janhalama commented 2 years ago

You can merge before https://github.com/superfaceai/service-client/pull/69. I will solve conflicts afterwards.