Remove URL and URLSearchParams - Githubissues

superfaceai / service-client

Library provides client for superface backend apis.

MIT License

5 stars 1 forks source link

Remove URL and URLSearchParams #72

Closed freaz closed 2 years ago

freaz commented 2 years ago

Description

Removes URL and URLSearchParams
Adds own function to crate query params string

Motivation and Context

service-client needs to run in Browser.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION_GUIDE document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

freaz commented 2 years ago

Found better way.

It is enoigh to remove the import and ude url from global scope. Which will work in node.js but also in browsers.

https://nodejs.org/api/url.html#class-url

https://caniuse.com/?search=url