fix: SDKConfigResponse can contain null - Githubissues

superfaceai / service-client

Library provides client for superface backend apis.

MIT License

5 stars 1 forks source link

fix: SDKConfigResponse can contain null #84

Closed kysely closed 2 years ago

kysely commented 2 years ago

Description

The SDKConfigResponse interface correctly defines possible nullable values.

Motivation and Context

Starting with OneSDK v2, the SDKInit event is not being sent to Brain when using with configuration in code.

As a result, the request for SDKConfig resource in Brain is calculated from Metrics events which don't include profile version, provider version and priority.

This breaks expectations of clients (e.g. Air), resulting in unexpected behaviors. See Slack for an example bug

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTION_GUIDE document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.