Closed smizell closed 3 years ago
@smizell is attempting to deploy a commit to the Superface Team on Vercel.
To accomplish this, @smizell needs to request access to the Team.
Afterwards, an owner of the Team is required to accept their membership request.
@zdne I've removed keys, tokens, and passwords from the context variables for now.
@zdne I've removed keys, tokens, and passwords from the context variables for now.
Thanks! Could you please comment on https://github.com/superfaceai/spec/pull/12#pullrequestreview-581291888 ?
Here are some comments in relation to https://github.com/superfaceai/spec/pull/12#pullrequestreview-581291888
Per your comment:
I think this is not an issue because every Map is Provider (definition) -specific
If we ever allow a map to use multiple providers, this will mean that we would need some way to say which security scheme we're using in which provider. As it is right now, there's one provider per map so it doesn't matter. I'm fine with it as is. I just wanted to make sure you knew.
Thanks @smizell ! I think we are good to go here.
Only thing I'd consider is the support for custom auth schemes like mixes of bearer and api key and anything people can come up with.
One organizational point: If we would merge this into master we would loose the production (= what is currently implemented in the parser) spec. Should we create a preview
or development
integration branch here, for approved features in the spec that are not yet implemented?
Instead of defining security schemes within a map, people will define security requirements that reference security schemes defined within a provider definition.
Decisions
SecuritySchemeIdentifier
which references the same identifier within a provider definition. We will reuse this as we create a provider specification.