fix: fix map spec operation call inconsistencies

superfaceai / spec

The Comlink Specification. Comlink is a new interface description and integration language build self-integrating applications.

https://superface.ai/docs/comlink/specification

MIT License

11 stars 1 forks source link

fix: fix map spec operation call inconsistencies #38

Closed TheEdward162 closed 2 years ago

TheEdward162 commented 2 years ago

Fixed inconsistencies around operation calls. Namely the possibility to leave out operation call argument list and statement "body" slot thing.

In parser, it is implemented according to these changes. If this should rather be fixed in parser I'll change this PR.

I also fixed a typo.

github-actions[bot] commented 2 years ago

Deploy preview for specification ready!

✅ Preview https://specification-n2zz7et5y-superface.vercel.app

Built with commit a53178626c96f7695d6460d9bad621d6060976b1. This pull request is being automatically deployed with vercel-action

jnv commented 2 years ago

I don't have much experience with the spec to review this, but please check examples 13 and 16 (and possibly others) where the comma is omitted between arguments. While the spec seems to make comma optional, the current implementation doesn't seem to work like this.

TheEdward162 commented 2 years ago

@martinalbert @jnv I've updated example 13 (the one with call FooWithArgs) to follow the spec. I didn't find any other instances of calls where the separators were missing