feat: Add geocoding provider `here`

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

feat: Add geocoding provider `here` #162

Closed martinalbert closed 2 years ago

martinalbert commented 2 years ago

Description

Adds new provider for address/geocoding profile

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

janhalama commented 2 years ago

@martinalbert We need to update parser in Superface services before merging.

martinalbert commented 2 years ago

Alright, I'll wait. Cli also need stable version before merging.

janhalama commented 2 years ago

We need to update parser in Superface services before merging.

@martinalbert I just realised that parser and ast have been updated already to version 1.1.0 in Superface services (Brain). I am not sure about the CLI, but Brain is ready.

janhalama commented 2 years ago

Looks good 👍