fix: Correctly mapping Crisp contacts without name - Githubissues

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

fix: Correctly mapping Crisp contacts without name #172

Closed kysely closed 2 years ago

kysely commented 2 years ago

Description

Fixes an issue with crm/contacts Crisp map that failed when Crisp returned a contact without a name.

It can occasionally return no name (undefined), an empty string or a string containing whitespace.

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.