Add `social-media/posts-lookup` profile with Twitter map

janhalama commented 2 years ago

Description

This PR adds social-media/posts-lookup profile with FindByHashtag and FindByMention use-cases. PR adds also maps for mock and twitter providers.

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

janhalama commented 2 years ago

"Lookup" instead of search implies that you have better idea what you are looking for, while search is rather more general. But I welcome any other suggestions.

I understand your concerns, Lookup sounds much more appropriate in this case.

janhalama commented 2 years ago

I think we don't have any use-case for fetching the profile ID from username in case of Twitter; IMO the SearchByMentions could accept username as an alternative to profileId? (can be extended later)

Right we do not have it. username seems to be appropriate naming as even Facebook requires to create username for Facebook page to be able to mention it.

janhalama commented 2 years ago

@jnv I changed the name of profile and use-cases as you proposed. 🙏

superfaceai / station