feat: Add `chat/messages` profile and slack map

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

feat: Add `chat/messages` profile and slack map #187

Closed martinalbert closed 2 years ago

martinalbert commented 2 years ago

Description

Adds profile for getting past messages in slack.

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

janhalama commented 2 years ago

@martinalbert is this ready for review? There are unfinished TODO tasks in the description.

jnv commented 2 years ago

I don't see this much as a blockers, Discord should be definitely in a separate PR, but if you have more tests in mind, it's better to do them now. :wink:

martinalbert commented 2 years ago

@janhalama @jnv it's ready, I removed discord from this PR and added missing things.

martinalbert commented 2 years ago

@jnv I've added better description and mapping. Also, I had to go with UNIX timestamp as slack does not return ISO format for date of message creation. I'll add rate limit information and finish up discord in another PR.

martinalbert commented 2 years ago

@janhalama @jnv I added some review fixes and also refactored mapping due to performance issues.

jnv commented 2 years ago

Ok to go, let's rather add URLs in a separate PR.