superfaceai / station

Comlink metadata for self-integrating applications.
https://superface.ai/catalog
MIT License
22 stars 5 forks source link

feat(oauth/refresh-token): Add twitter provider #197

Closed jnv closed 2 years ago

jnv commented 2 years ago

Description

Follow up to #196. This adds the Twitter as a oauth/refresh-token provider in addition to these changes:

Technically adding a new property to result is a minor change, but I'd like to merge this along with #196 which isn't yet released, so there's no need for version change.

Motivation and Context

Types of changes

Checklist:

janhalama commented 2 years ago

I'd like to merge this along with https://github.com/superfaceai/station/pull/196 which isn't yet released, so there's no need for version change.

Publishing is triggered by GA after merging to main. How are you goign to avoid running publish action for https://github.com/superfaceai/station/pull/196?

jnv commented 2 years ago

@janhalama Publishing is triggered by GA after merging to main. How are you goign to avoid running publish action for https://github.com/superfaceai/station/pull/196?

Will the publishing of 196 prevent me from publishing this one? My point is that the initial version will be so short-lived it won't break anything for anyone (and Google APIs map doesn't need any change).

But if this is a problem, I could merge this PR into 196 and then publish it in one go.

jnv commented 2 years ago

Alternatively I could just cancel the CI action once I merge #196...

janhalama commented 2 years ago

Will the publishing of 196 prevent me from publishing this one?

Yes, Brain response will be:

image

I am ok with proposed solutions.