search

superfaceai / station

Comlink metadata for self-integrating applications.
https://superface.ai/catalog
MIT License
22 stars 5 forks source link

fix(twitter): Revert twitter provider parameters #200

Closed jnv closed 2 years ago

jnv commented 2 years ago

This reverts integration parameters changes to Twitter provider introduced in #197. Providers are immutable and cannot be updated just like this. Additionally these parameters are (so far) used only by oauth2/refresh-token profile, which might be confusing in context of other profiles.

Currently integration parameters can be passed to the map even when not specified in provider JSON, so I am keeping this behavior with the existing refresh-token map. The cleaner (though not universal) solution here would be to use default inputs.

jnv commented 2 years ago

@janhalama Good point, I can totally see a possibility to move access token to a dedicated security (?) parameter as well.

janhalama commented 2 years ago

@janhalama Good point, I can totally see a possibility to move access token to a dedicated security (?) parameter as well.

We already have it!? We can use Bearer token security scheme: https://superface.ai/docs/comlink/reference/provider#bearer-token

jnv commented 2 years ago

We already have it!? We can use Bearer token security scheme: https://superface.ai/docs/comlink/reference/provider#bearer-token

So, how do you pass the access token in the runtime into the perform?