`freegeoip` provider is now `ipbase` - Githubissues

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

`freegeoip` provider is now `ipbase` #251

Closed janhalama closed 2 years ago

janhalama commented 2 years ago

Description

ipbase acquired freegeoip

Motivation and Context

This PR adds new ipbase provider and map for ip-geolocation profile.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

janhalama commented 2 years ago

Consider removing freegeoip, it will remain published but we don't need to keep it in Station (unless we plan to somehow depreciate it more properly).

I agree, I removed freegeoip from Station.