fix(vcs): Smaller array size in pagination hack - Githubissues

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

fix(vcs): Smaller array size in pagination hack #269

Closed Jakub-Vacek closed 2 years ago

Jakub-Vacek commented 2 years ago

This PR fixes problem with allocation of large size Array during pagination.

Fixes: https://github.com/superfaceai/station/issues/266

Description

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Jakub-Vacek commented 2 years ago

Geocoding tests are failing 🤔 VCS tests pass correctly(there isn't any auth).

Jakub-Vacek commented 2 years ago

Okey, so some are just flaky :/