feat: Include entity type in Id for use case `CreateCandidate`

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

feat: Include entity type in Id for use case `CreateCandidate` #317

Closed martinalbert closed 1 year ago

martinalbert commented 1 year ago

Description

Adds entity type prefix to id of candidate.

Motivation and Context

Discussion in this comment, main reason is support other use cases with different providers.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

janhalama commented 1 year ago

@martinalbert do we need it in case of Breezy HR provider? If I remember it well Breezy HR API has single id pool for candidates and leads.

martinalbert commented 1 year ago

Yes, workable should also have common pool, this was meant for other providers.

janhalama commented 1 year ago

Yes, workable should also have common pool, this was meant for other providers.

I do not see the reason for adding the entity prefix in case of providers with single id pool for both candidates and leads. Structure of the ID is opaque for the client. We should be able to use directly the ID of the entity in case of Breezy HR and Workable providers.

martinalbert commented 1 year ago

Ok I misunderstood, it's different with breezy, but both have common id pool for lead and candidate. Breezy does not have stage sourced, you create a candidate with origin of sourced, but starts in first stage of a pipeline which is by default applied.

martinalbert commented 1 year ago

Closing this - not needed at the moment.