feat: Add booking/list-activities

tmladek commented 1 year ago

Description

Adds "List Activities" profile for booking, and a map for Bokun.io

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

tmladek commented 1 year ago

Thanks in advance for the review! Also not sure why the lint of the example isn't passing - I'd appreciate any help!

jnv commented 1 year ago

There are a few critical issues, but before addressing that, I'd like to discuss naming. Since "booking" is overloaded with hospitality and services industrie, maybe we could use some other scope? For example tour (from Tour Operator Software) or travel?

tmladek commented 1 year ago

I'd definitely prefer tour over travel - I'd expect travel to include stuff like bus/plane/train tickets, connections, etc. - things explicitly connected with the act of travelling (for both leisure and business purposes). tour doesn't have that, but IMHO feels too restrictive - tours are just one category from the offerings available on e.g. Bokun, the rest not being very tour-like (and by the way, generally falling under the term "activities" - which also isn't very suitable as a scope name), meaning tours may be a bit misleading.

Really, I feel like booking is the most appropriate and accurate scope name, as booking a trip/tour/activity - or managing said booking - is somewhat of a "final destination" of any application using these profiles.

superfaceai / station