fix: run CI/CD pipeline for public fork pull requests - Githubissues

superfaceai / station

Comlink metadata for self-integrating applications.

https://superface.ai/catalog

MIT License

22 stars 5 forks source link

fix: run CI/CD pipeline for public fork pull requests #365

Closed tmladek closed 1 year ago

tmladek commented 1 year ago

Description

Hopefully also runs CI/CD pipeline for outside collaborators' pull requests (e.g. #363)

Motivation and Context

Going forward, we may expect more PRs that do not originate from the origin superfaceai/station repo.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

tmladek commented 1 year ago

Right, so this seems like it runs everything twice 🤔

Perhaps concurrency might help? https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency

jnv commented 1 year ago

@tmladek Consider changing the triggers to run action only on push to main. That's actually the recommended approach: https://github.com/orgs/community/discussions/26276#discussioncomment-3251140