search

superfeedr / indexeddb-backbonejs-adapter

An indexedDB adapter for Backbonejs
http://blog.superfeedr.com/indexeddb-backbonejs-adapter/
MIT License
248 stars 61 forks source link

ff10 support after new W3C upgrade path based on onupgradeneeded event #6

Closed lcalvy closed 11 years ago

odinho commented 12 years ago

This should prolly be merged :-)

Fixes my pull request about removing that legacy ES3 _continue stuff.

julien51 commented 12 years ago

I think at the time I did not merge because the tests wouldn't pass. I'll have to check that again.

odinho commented 12 years ago

Please do, -- they probably won't pass because they're wrong if anything. I also have a patch fixing one of the tests, maybe you should take that one first?

julien51 commented 12 years ago

"This pull request cannot be automatically merged." Not lookoing good given the very little time I have.

Please make it easier for me to merge your patches, it will make that happen earlier!

odinho commented 12 years ago

Waiting 9 months to merge something doesn't really help... It's not my patch though, - I had a smaller patch, but saw that this one also fixes my problem. Anyway, take a look at #15.

I might clean this one up and make it mergeable if Icalvy doesn't do it first. But have other burning stuff to fix first :P