search

superfeedr / subtome

A universal Subscribe/Follow button.
http://subtome.com
MIT License
167 stars 32 forks source link

Redirect loop when using "RSS Feed" and the Extension RSS Subscription Extension #50

Closed julien51 closed 10 years ago

julien51 commented 11 years ago

The RSS Subscription Extension seems to be creating an infinite loop.

Thanks to @graham_alton.

julien51 commented 10 years ago

Hum. This is tricky. It looks like This Chrome extension opens a new tab and reloads the previous url which is why it creates a infinite loop. Now to understand why it does a redirect and how to avoid it by reading source code at https://github.com/justinkelly/chrome-rss by @justinkelly !

julien51 commented 10 years ago

I now see 2 ways to avoid that: open a new tab in SubToMe with window.open and close the current one (but I'm afraid this will trigger popup blockers), or mess with window.history (which may be incompatible with some older browsers). Yikes.

justinkelly commented 10 years ago

hey guys

there are a number of rss subscription extension in the chrome store based off the same code - if you find anything that needs to be done in my extension to make it work - i'll apply it - but you may have to ask a number of extensions to update their code

also i wouldnt assume that many people use both subtome and an alternate rss subscript extensions - as both do the same thing - just differently

cheers

justin

julien51 commented 10 years ago

Thanks for coming here @justinkelly. I think I found a way to solve that by tweaking the history. This code will be deployed very soon.