Closed lloydwatkin closed 10 years ago
LLoyd, I am so sorry you worked on this, because no later than this morning I added support for data-*
attributes in SubToMe so that it's easy to configure.
Check #60 while I'm updating the docs.
That is great! Will update the code here and let you know how it goes. I had started on using data-*
attributes myself :)
I'll first point you at a quick email between @julien51 and myself:
Quick, clear response:
Yeah, thing is I'm a lazy developer and really couldn't be bothered to do all of this. Ok, the fact that I'm making a PR contradicts that point, but I wanted it to be easier to achieve what I was after.
So what this pull request does is add an additional file very similar to
load.js
but isn't a self-calling anonymous function. We load theload-custom.js
script from subtome.com in the normal way and then callsubToMe()
in myonclick
event. This works just the same as the existingload.js
script (i.e. it will scrape the page for RSS feeds).Now if I pass an argument, that argument becomes the feed URL so I can point my subscribe links at different feeds instead.
You may think this is unnecessary, but I thought I'd make the PR just in case you thought it was a useful addition. In the project I made this for I've included the script locally to get the same functionality. The advantage of it being in the subtome repo is that it gets the love of upgrades and bug fixes that everyone benefits from :)
Thanks, Lloyd.