mime-type whitelist instead of blacklist

superfeedr / subtome

A universal Subscribe/Follow button.

http://subtome.com

MIT License

167 stars 32 forks source link

mime-type whitelist instead of blacklist #65

Closed pfefferle closed 10 years ago

pfefferle commented 10 years ago

What about a whitelist of mime-types instead of the used blacklist:

['application/wiki', 'application/json', 'application/activitystream+json'].indexOf(links[i].type) == -1 )

If we stay with the blacklist, we have to add:

application/activity+json
application/stream+json

(see http://tools.ietf.org/html/draft-snell-activitystreams-05#section-6 sub-section 1.)

julien51 commented 10 years ago

I'm not sure what's better as the risk of false positives is pretty high. Some people just don't use the right mime-type for Atom/RSS and I don't want to exclude these feeds by default.

pfefferle commented 10 years ago

Then we should add the two types I listed above.