superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 239 forks source link

[SUBGRAPH] fix resolver entry #1843

Closed 0xdavinchee closed 8 months ago

0xdavinchee commented 9 months ago

we move this: resolverEntry.isToken = Token.load(target.toHex()) != null; out of the resolverEntry == null and only update it if the target is not null.

We need to do this because of sepolia where the token entity is created after the resolver set event is emitted (triggered), thus we want to be able to call set again and fix this. Edited: This makes ETHx not shown as listed in sepolia subgraph.

hellwolf commented 8 months ago

how is this one doing

hellwolf commented 8 months ago

the fix did not work, will be investigated.

hellwolf commented 8 months ago

@elvijsTDL please write a concrete bug report on the issue related to this.

elvijsTDL commented 8 months ago

The subgraph shows some of the tokens as unlisted even if they should be e.g. ETHx , fUSDCx

If you query the listed tokens you can see that they are missing:

  tokens(where: {isListed: true}) {
    isListed
    isSuperToken
    isNativeAssetSuperToken
    name
    symbol
  }
}

Screenshot 2024-03-22 at 11 56 16

At some point it has flipped from listed to unlisted as it used to work fine

This might be related to GoodDollar G$ getting unlisted from Celo too

github-actions[bot] commented 8 months ago

XKCD Comic Relif

Link: https://xkcd.com/1843 https://xkcd.com/1843