In #1879 we fixed an issue with the FlowNFTs: the hooks for minting and burning were wrapped in a try/catch and could fail with outofgas. This happened despite code supposed to avoid exactly that.
The Pool NFTs use the same mechanism. We haven't yet observed such internal reverts, but currently can't be confident the same could happen.
AC
[x] Remove try/catch from PoolNFT hooks & make sure there's no code path where it could revert
What & Why
In #1879 we fixed an issue with the FlowNFTs: the hooks for minting and burning were wrapped in a try/catch and could fail with outofgas. This happened despite code supposed to avoid exactly that. The Pool NFTs use the same mechanism. We haven't yet observed such internal reverts, but currently can't be confident the same could happen.
AC