search

superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 240 forks source link

[ETHEREUM-CONTRACTS] add missing batch call operations #1967

Closed d10r closed 4 months ago

d10r commented 5 months ago

Adds missing batch call operations, see https://github.com/superfluid-finance/protocol-monorepo/issues/1895

github-actions[bot] commented 5 months ago

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

kasparkallas commented 4 months ago

@d10r Is the main idea to delegate non-SuperApp and non-Superfluid batch operations through the new DMZForwarder contract?

d10r commented 4 months ago

@d10r Is the main idea to delegate non-SuperApp and non-Superfluid batch operations through the new DMZForwarder contract?

For the Generic Call Proxies (see https://github.com/superfluid-finance/protocol-monorepo/issues/1895) yes.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (31453f8) to head (84bb8ba).

:exclamation: Current head 84bb8ba differs from pull request most recent head 524ae94

Please upload reports for the commit 524ae94 to get more accurate results.

Files Patch % Lines
...reum-contracts/contracts/superfluid/SuperToken.sol 33.33% 4 Missing :warning:
...thereum-contracts/contracts/utils/DMZForwarder.sol 42.85% 4 Missing :warning:
...m-contracts/contracts/apps/SuperTokenV1Library.sol 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1967 +/- ## ========================================== - Coverage 88.60% 88.53% -0.07% ========================================== Files 118 119 +1 Lines 7361 7388 +27 Branches 967 975 +8 ========================================== + Hits 6522 6541 +19 - Misses 837 845 +8 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1967/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | Coverage Δ | | |---|---|---| | [ethereum-contracts](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1967/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `94.04% <75.00%> (-0.18%)` | :arrow_down: | | [sdk-core](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1967/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `88.53% <75.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

XKCD Comic Relif

Link: https://xkcd.com/1967 https://xkcd.com/1967