superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 240 forks source link

[automations] Vesting Scheduler V2 refactoring after single-transfer feature #1969

Closed kasparkallas closed 4 months ago

kasparkallas commented 5 months ago

Why?

The single-transfer feature for claiming after the end date created code duplication and made it hard to follow from bird's eye view what was happening, making bugs easy to miss and contract harder to audit.

What?

Refactored to additional private functions to alleviate code duplication and to make it clearer at a glance what's happening.

Notes

Test version with smaller timeframes deployed here: https://sepolia-optimism.etherscan.io/address/0xF0789B3B229b00D81473935f84960E4435e430b4#code

github-actions[bot] commented 4 months ago

XKCD Comic Relif

Link: https://xkcd.com/1969 https://xkcd.com/1969