superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 240 forks source link

GDA Units Self Transfer #1972

Closed hellwolf closed 4 months ago

hellwolf commented 4 months ago

Superfluid pool to prevent self-transfer, which is a footgun for developers.

Before this change, the pool unit owner must be an contract and limit self transfer. This change will further limit this possibility.

Additionally, in order to test properly, one must not "fuzz" full address space, which will fail to produce self-transfer cases.

github-actions[bot] commented 4 months ago

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.60%. Comparing base (f113f5e) to head (116cba2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1972 +/- ## ======================================= Coverage 88.60% 88.60% ======================================= Files 118 118 Lines 7360 7361 +1 Branches 966 967 +1 ======================================= + Hits 6521 6522 +1 Misses 837 837 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1972/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | Coverage Δ | | |---|---|---| | [ethereum-contracts](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `94.21% <100.00%> (+<0.01%)` | :arrow_up: | | [sdk-core](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `88.60% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

XKCD Comic Relif

Link: https://xkcd.com/1972 https://xkcd.com/1972