superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 240 forks source link

[ETHEREUM-CONTRACTS] relax solidity pragma ^0.8.23 & update to 0.8.26 #1981

Closed hellwolf closed 4 months ago

hellwolf commented 4 months ago
github-actions[bot] commented 4 months ago

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

hellwolf commented 4 months ago

@d10r this one too, please

hellwolf commented 4 months ago

Upgrading solidity to 0.8.26.

Found an foundry bug https://github.com/foundry-rs/foundry/issues/8342 which resulted a difficult to find culprit file.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.53%. Comparing base (668d475) to head (d43812c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1981 +/- ## ======================================= Coverage 88.53% 88.53% ======================================= Files 119 119 Lines 7389 7389 Branches 977 976 -1 ======================================= Hits 6542 6542 Misses 845 845 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1981/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | Coverage Δ | | |---|---|---| | [ethereum-contracts](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `94.04% <ø> (ø)` | | | [sdk-core](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/1981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `88.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

XKCD Comic Relif

Link: https://xkcd.com/1981 https://xkcd.com/1981