search

superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 240 forks source link

[ETHEREUM-CONTRACTS] per chain configurable app callback gas limit #1982

Closed d10r closed 4 months ago

d10r commented 4 months ago

fixes https://github.com/superfluid-finance/protocol-monorepo/issues/1975

github-actions[bot] commented 4 months ago

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

d10r commented 4 months ago

In https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/ethereum-contracts/contracts/utils/SuperfluidFrameworkDeploymentSteps.sol#L46:

    bool public constant DEFAULT_NON_UPGRADEABLE = false;
    bool public constant DEFAULT_APP_WHITELISTING_ENABLED = false;

but not used:

host = SuperfluidHostDeployerLibrary.deploy(true, false, 3_000_000, address(dmzForwarder));

(not even using the same values, thus I didn't just replace with the constants)

There seems to be no mechanism to configure those when using this deployer, thus I also hardcode the value for app callback gas limit.

hellwolf commented 4 months ago

Three-way merging #1979 branch for testing purpose.

github-actions[bot] commented 4 months ago

XKCD Comic Relif

Link: https://xkcd.com/1982 https://xkcd.com/1982