search

superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
874 stars 239 forks source link

[JS-SDK] defunct actions in User.js #2034

Open d10r opened 3 weeks ago

d10r commented 3 weeks ago

What & Why

When working on https://github.com/superfluid-finance/protocol-monorepo/pull/2032, it was noticed that in https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/js-sdk/src/User.js#L102 there's code which superficially looks like GDA wrapping, but invokes IDA functionality. It's likely broken and to be removed.

hellwolf commented 3 weeks ago

Who is using the JS-SDK for that? It's been deprecated, and only our own dev/ops-scripts are using it.