Open d10r opened 2 weeks ago
Reminder to update the CHANGELOG.md for any of the modified packages in this PR.
Attention: Patch coverage is 83.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 87.99%. Comparing base (
0b33f76
) to head (8e6a20a
).
Files with missing lines | Patch % | Lines |
---|---|---|
...reum-contracts/contracts/superfluid/SuperToken.sol | 80.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
note: BaseRelayRecipient._getTransactionSigner()
does not do what it's natspec claims.
Needed changes:
IRelayRecipient
, trusting the DMZForwardermsg.sender
with_msgSender()
(which uses the 2771-encoded sender if present)Here only
SuperToken.increaseAllowance()
was changed that way, with a new test case using it.In order to do this, we'd need to
_msgSender()
in all SuperToken methodsAs long as there's SuperTokens not updated to this logic, we can't easily remove the then legacy operations types from batch call.
However we could remove the code from SuperToken if we conditionally re-map legacy operations in
Superfluid.sol
to use 2771Forwarder if the target token contract supports it.