superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
872 stars 237 forks source link

[SDK-CORE] Proposal to use graphprotocol/graph-client #969

Closed 0xdavinchee closed 3 days ago

0xdavinchee commented 2 years ago

Summary

The Graph awarded a $48M grant to "The Guild" in December 2021 and is committing to directly help The Graph develop core subgraph features. NOTE: The Guild is one of the top open-source developer groups in the GraphQL ecosystem. For more details on the grant.

Proposal

I believe that when we extract the Query capabilities from the SDK-Core, we should change our tooling and use the graph-client which is developed and maintained by The Guild.

Using this tool means that we no longer have to maintain and worry about the implementation of the intricacies surrounding GraphQL, but instead leverages the knowledge of The Guild and uses the abstraction in this library to accomplish what we need.

This library solves a lot of problems (and has new features we don't currently have) which we are solving manually by combining a few different libs probably developed by The Guild anyways.

Drawbacks

hellwolf commented 11 months ago

Is this one still relevant?

0xdavinchee commented 11 months ago

Is this one still relevant?

I'd say so-the products team are already using this over the ad-hoc approach we have.