search

superfluid-finance / widget

https://checkout-builder.superfluid.finance
MIT License
15 stars 9 forks source link

chore: "moduleResolution": "NodeNext" #199

Closed kasparkallas closed 1 year ago

kasparkallas commented 1 year ago

In a consumer project, running Node without bundling, ran into issues with the imports. To ensure this doesn't happen, the "moduleResolution" should be set to "NodeNext" as per TypeScript documentation and blog: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler _"On the other hand, if you’re writing a library that’s meant to be published on npm, using the bundler option can hide compatibility issues that may arise for your users who aren’t using a bundler. So in these cases, using the node16 or nodenext resolution options is likely to be a better path."

Alternative to doing this is to run a minimal bundle/transipiling process before publishing.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **widget-b2b-service-demo** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-b2b-service-demo/ErSZ2Vc3sSngwrrj2KbpoykMyyp3)) | [Visit Preview](https://widget-b2b-service-demo-git-change-mo-6a1af7-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am | | **widget-builder** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-builder/DMqkiu88EXUsH6w9mZaRcutYCg9j)) | [Visit Preview](https://widget-builder-git-change-module-and-5ff01f-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am | | **widget-donation-demo** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-donation-demo/2uiYMyNsY7VTf1RqUJCsHT3J9n6g)) | [Visit Preview](https://widget-donation-demo-git-change-modul-6954cc-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am | | **widget-gated-community-demo** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-gated-community-demo/CQ6iu7qGvnRwTCwGiwobNZCQeN28)) | [Visit Preview](https://widget-gated-community-demo-git-chang-2f21c7-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am | | **widget-hosted** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-hosted/4nLwpK1yTh7p5BjakgDrdtR5th7Y)) | [Visit Preview](https://widget-hosted-git-change-module-and-m-cf37a6-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am | | **widget-reference-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/superfluid-finance/widget-reference-docs/FF93MKCwHxuh6gFER6Pb5sNcQvRh)) | [Visit Preview](https://widget-reference-docs-git-change-modu-ad397d-superfluid-finance.vercel.app) | Sep 27, 2023 10:58am |