Possible race in PG endpoint's commit handling

superfly / corrosion

Gossip-based service discovery (and more) for large distributed systems.

https://superfly.github.io/corrosion/

Apache License 2.0

684 stars 21 forks source link

Possible race in PG endpoint's commit handling #176

Open jeromegn opened 6 months ago

jeromegn commented 6 months ago

When an explicit transaction (started with a BEGIN from the client) ends, it should be rolled back. This is not currently the case when an error occurs, for example.

jeromegn commented 3 months ago

We should fix this at some point. IIRC it caused some issues when I tested it in development, but in general the way it works makes more sense than before. Must've introduced a bug.