superfly / docs

Apache License 2.0
101 stars 1.06k forks source link

Issue with the "Fly Launch configuration (fly.toml)" doc #1662

Open fliepeltje opened 4 months ago

fliepeltje commented 4 months ago

I found an issue with this document.

Title: Fly Launch configuration (fly.toml) Location: https://fly.io/docs/reference/configuration/ Source: https://github.com/superfly/docs/blob/main/reference/configuration.html.markerb

Describe the issue

The gpu kind is incorrect in the vm section; this concerns the code block.

It should be this instead for the GPUs:

[[vm]]
  size = "shared-cpu-2x"
  memory = "2gb"
  cpus = 4
  cpu_kind = "performance"
  gpus = 1
  gpu_kind = "a100-40gb"
  kernel_args = "no-hlt=true"
  host_dedication_id = "customer-id"
  processes = ["app"]

In addition, I get an error with the kernel_args param if I run as-is

VaibhavVasdev commented 4 months ago

Hi @fliepeltje, I would like to fix the documentation part. Can you please assign me the issue.

VaibhavVasdev commented 4 months ago

Hi @fliepeltje, I have created a Pull Request to correct the "gpu_kind" part in the documentation. You can find it here