search

superfly / fly-pr-review-apps

Github Action for PR Review Apps on Fly.io
Apache License 2.0
186 stars 116 forks source link

Fix description for secrets #28

Closed svenluijten closed 11 months ago

svenluijten commented 1 year ago

FIRST_SECRET=${{ secrets.FIRST_SECRET }} SECOND_SECRET=${{ secrets.SECOND_SECRET }} would be expanded by the runner when not enclosed in quotes.

As done in #17, but in a separate PR for ease of reviewing.

wmnnd commented 1 year ago

Hey, I think just adding the quotes doesn’t do the trick. GitHub still tries to do the variable replacement. I just went with this:

  secrets:
    description: "Secrets to be set on the app. Separate multiple secrets with a space, i.e., `FIRST_SECRET=foo SECOND_SECRET=bar`"