Add missing dockerfile path to append it in launch command

superfly / fly-pr-review-apps

Github Action for PR Review Apps on Fly.io

Apache License 2.0

186 stars 116 forks source link

Add missing dockerfile path to append it in launch command #52

Open som-matrix opened 6 months ago

som-matrix commented 6 months ago

Added documentation for a new input parameter "dockerfile", which allows specifying a custom Dockerfile path for the build process. This addition provides flexibility in managing different Docker configurations.

action.yml

Streamlined Inputs: Modified the action's inputs by introducing the dockerfile input for specifying Dockerfile paths directly.

entrypoint.sh

Implemented support for specifying custom Dockerfile paths, increasing flexibility in Docker image construction.

som-matrix commented 5 months ago

Hi folks , please review this when you are free

brecke commented 4 months ago

This would allow me to skip building my own image during the github action thus saving a lot of billable minutes. Is there something preventing this from being merged? Anything I can do to help?

som-matrix commented 3 months ago

gentle reminder folks, please review this when you are free

jsierles commented 2 months ago

Hey - it looks like this requires setting a Dockerfile. Wouldn't this be a breaking change?