som-matrix commented 6 months ago

This PR introduces the ability to control the deployment behavior of the Fly app within our GitHub Actions workflow. Users can now specify whether the deployment should run in a detached mode, which allows the GitHub Actions runner to proceed without waiting for the deployment to complete. This feature is particularly useful for workflows where immediate feedback from the deployment process is not necessary, helping to reduce wait times and potential bottlenecks in continuous integration pipelines.

Changes

Added a new environment variable INPUT_WAIT, which users can set to true if they wish for the deployment to wait until completion. By default, the deployment runs in detached mode.
Modified the flyctl deploy command to accept a --detach flag based on the INPUT_WAIT setting, enabling either immediate return or waiting for the deployment process.

som-matrix commented 5 months ago

Hi folks , please review this when you are free

som-matrix commented 5 months ago

Hi folks gentle reminder , please review this when you are free

som-matrix commented 3 months ago

gentle reminder folks, please review this when you are free

superfly / fly-pr-review-apps