search

superfly / fly-pr-review-apps

Github Action for PR Review Apps on Fly.io
Apache License 2.0
186 stars 116 forks source link

fix: flyctl deploy flag from region to regions #56

Closed bryantbrock closed 5 months ago

bryantbrock commented 5 months ago

flyctl v0.2.47 [PR] silently broke everyones CI/CDs. It broke my review apps. This fixes that change.

This really needs to go out ASAP as it breaks ALL review apps until it's fixed. I'm changing mine to manually run this code until this is merged in and released.

bryantbrock commented 5 months ago

ETA on getting merged in?

ragbadaskar commented 5 months ago

@bryantbrock how do we manage the situation till this PR is merged? Can we use the edits your made in the steps?

Liinkiing commented 5 months ago

@bryantbrock how do we manage the situation till this PR is merged? Can we use the edits your made in the steps?

Yes you can, that's what I'm doing (thanks @bryantbrock)

In your workflow, you can update the uses to 

        uses: bryantbrock/fly-pr-review-apps@6e34c6a6405b85220fb22ee564d32ce89c3dc384

✨

ragbadaskar commented 5 months ago

Thanks for the merge. I'm trying to push preview app but fails with the same error. uses: superfly/fly-pr-review-apps@1.2.0

There is no version change. So what am I missing?

Thank you @bryantbrock for the patch.

clouvet commented 5 months ago

@ragbadaskar you should see a new release now, v1.2.1.