superfly / fly

Deploy app servers close to your users. Package your app as a Docker image, and launch it in 17 cities with one simple CLI.
https://fly.io
985 stars 48 forks source link

Files in inner package.json will strip their dependent files. #183

Closed jphenow closed 5 years ago

jphenow commented 5 years ago

Having inner package.jsons with files specified effectively means it ignores non-listed items. This means that these two examples were excluding their prebuilt code (because of how they're configured).

This is probably not a real fix considering there are other default things ignored, but perhaps that doesn't matter. To restore the template functionality for now, I'd recommend commenting them out. For future I can think of a few options:

Docs: https://docs.npmjs.com/files/package.json#files

Addressing #182

jphenow commented 5 years ago

For more context, you can:

Do the same on this branch to see difference

jphenow commented 5 years ago

And if it makes you feel better - due to the explanation above - this should only affect load-balancer and rate-limiter templates

mrkurt commented 5 years ago

Whoah good find. This is a good fix, we shouldn't need those file filters for examples since they won't be published independently.

mrkurt commented 5 years ago

You cool with me merging this?

jphenow commented 5 years ago

Absolutely