search

superfly / fly

Deploy app servers close to your users. Package your app as a Docker image, and launch it in 17 cities with one simple CLI.
https://fly.io
985 stars 48 forks source link

Exit if secrets cannot be applied #225

Closed jeromegn closed 4 years ago

jeromegn commented 5 years ago

If we can't generate a config due to a missing secret, the process does not exit and just keeps going.

Example:

Error: Expected secret 'secretKey' to be defined in secrets
    at Object.applySecrets (./node_modules/@fly/core/lib/utils/app.js:16:27)
    at App.get config [as config] (./node_modules/@fly/core/lib/app.js:24:15)
    at App.asJSON (./node_modules/@fly/core/lib/app.js:45:26)
    at App.forV8 (./node_modules/@fly/core/lib/app.js:51:45)
    at LocalRuntime.runApp (./node_modules/@fly/core/lib/local_runtime.js:83:35)
    at LocalRuntime.setApp (./node_modules/@fly/core/lib/local_runtime.js:95:24)
    at buildAppWithConfig (./node_modules/@fly/core/lib/cmd/test.js:64:22)

and then the process just keeps running.